Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collapsible animation #3148

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix collapsible animation #3148

merged 1 commit into from
Dec 18, 2024

Conversation

colleenmcginnis
Copy link
Contributor

In collapsible blocks, only animate the icon before the summary that is a direct child of the details element.

@colleenmcginnis colleenmcginnis self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review December 17, 2024 23:14
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner December 17, 2024 23:14
shainaraskas
shainaraskas approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested using this - lgtm!

@colleenmcginnis colleenmcginnis merged commit 0ad6e07 into elastic:master Dec 18, 2024
5 checks passed
@colleenmcginnis colleenmcginnis deleted the animate-collapsible branch December 18, 2024 17:21
naemono pushed a commit to naemono/docs that referenced this pull request Dec 18, 2024
@colleenmcginnis @naemono
fix collapsible animation (elastic#3148)
7b275b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

@lcawl lcawl Awaiting requested review from lcawl lcawl is a code owner automatically assigned from elastic/docs-repo-owners

@kilfoyle kilfoyle Awaiting requested review from kilfoyle kilfoyle is a code owner automatically assigned from elastic/docs-repo-owners

Assignees

@colleenmcginnis colleenmcginnis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colleenmcginnis @shainaraskas