Skip to content

Clean up raw files, fix malformed tables, rm unused subs #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

Clean up raw files, fix malformed tables, rm unused subs #860

merged 3 commits into from
Mar 20, 2025

Conversation

shainaraskas
Copy link
Collaborator

@shainaraskas shainaraskas commented Mar 20, 2025 •
edited
Loading

This PR:

  • Removes raw files I believe are used where they need to be used + their toc entries. generally:
    • 1:1 mapping with a page in the IA, populated with all of the content (and related reorg PRs are closed)
      OR
    • I know the area and reviewed the PRs that merged/split the content, and there are no stray mappings to the page
  • Fixes tables that had an empty heading row and then a clear actual heading data row
  • Removes unused subs (still throwing a warning due to Substitution key hint shows even when a sub is used docs-builder#779)

@shainaraskas shainaraskas changed the title Clean up raw files, fix malformed tables Clean up raw files, fix malformed tables, rm unused subs Mar 20, 2025
@shainaraskas shainaraskas marked this pull request as ready for review March 20, 2025 21:47
lcawl
lcawl approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed only, but LGTM

@shainaraskas shainaraskas merged commit 94f87a0 into main Mar 20, 2025
4 checks passed
@shainaraskas shainaraskas deleted the cleanup-sr branch March 20, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shainaraskas @lcawl