Skip to content

Remove invalid mapped_pages #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

Remove invalid mapped_pages #2992

merged 2 commits into from
Sep 17, 2025

Conversation

reakaleek
Copy link
Member

No description provided.

@reakaleek reakaleek requested review from a team as code owners September 17, 2025 11:57
@reakaleek
Copy link
Member Author

reakaleek commented Sep 17, 2025 •
edited
Loading

Needed for elastic/docs-builder#1899

We cannot process mapped_pages if they are not /guide links. Hence, elastic/docs-builder#1899 will force it and error if the URL does not start with https://www.elastic.co/guide

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2025 •
edited
Loading

🔍 Preview links for changed docs

kilfoyle
kilfoyle approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@reakaleek reakaleek enabled auto-merge (squash) September 17, 2025 14:45
@reakaleek reakaleek merged commit d90347d into main Sep 17, 2025
6 checks passed
@reakaleek reakaleek deleted the feature/remove-invalid-mapped-pages branch September 17, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theletterf theletterf theletterf approved these changes

@kilfoyle kilfoyle kilfoyle approved these changes

@colleenmcginnis colleenmcginnis Awaiting requested review from colleenmcginnis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reakaleek @theletterf @kilfoyle