Preload fonts in use as per CSS definitions #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Mpdreamz
requested changes
Mar 18, 2025
|
|
||
| public static partial class FontPreloader | ||
| { | ||
| private static List<string>? FontUriCache = null!; |
There was a problem hiding this comment.
readonly field or getter only property.
Also IReadOnlyCollection instead of List.
There was a problem hiding this comment.
Does this need to be thread safe?
There was a problem hiding this comment.
Ah. Nevermind. If I understood correctly, the whole logic is only executed once.
| private static List<string>? FontUriCache = null!; | ||
|
|
||
| public static async Task<IEnumerable<string>> GetFontUrisAsync() => FontUriCache ??= await LoadFontUrisAsync(); | ||
| public static async Task<List<string>> LoadFontUrisAsync() |
| return FontUriCache; | ||
| } | ||
|
|
||
| [GeneratedRegex(@"url\([""']?([^""'\)]+)[""']?\)", RegexOptions.Multiline | RegexOptions.Compiled)] |
There was a problem hiding this comment.
Maybe stricter including src: key?
There was a problem hiding this comment.
What do you think about adding also the file extension here.
the url function could in theory load any kind of file.
reakaleek
reviewed
Mar 18, 2025
| foreach (Match match in matches) | ||
| { | ||
| if (match.Success) | ||
| FontUriCache.Add($"/_static/{match.Groups[1].Value}"); |
There was a problem hiding this comment.
I think we need to add the url path prefix here.
But nice! I can see it's the first being loaded.
reakaleek
reviewed
Mar 18, 2025
reakaleek
reviewed
Mar 18, 2025
cotti
changed the title
Mpdreamz
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to preload fonts, a hint must be given to the browser in the form of a tag:
<link rel="preload" href="/path/to/font.woff2" as="font" type="font/woff2" crossorigin>This PR includes a cached repository for the font definitions in .css files so we don't need to worry about adding these if fonts change.
Handles #704