Repository navigation
Keep the API page feedback prompt in the article column - #4821
Merged
Merged
Conversation
On wide screens the prompt spanned both grid columns. Its top border ran under the examples rail, and on long endpoint pages the sticky rail overlapped it. The rail already sits in row 1 only, so the prompt in row 2 stays below the rail without the span. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![infra-vault-gh-plugin-prod[bot]](https://avatars.githubusercontent.com/u/6764390?s=60&v=4){kind=small}
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4821/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On API pages at 1024px and wider, the "Was this page helpful?" prompt now ends the article column. It no longer stretches under the examples rail.
Affects:
Site UI,API referencePrompt summary: The feedback prompt on API pages looks like it has a minimum width that makes it span the whole page width. The ask is to remove that so the prompt stops spanning the full width.
Why
The stretch comes from the grid, not a
min-width. Thepage-feedbackelement spans both columns of.api-page-grid, so its top border runs under the examples rail. On long endpoint pages the sticky rail stays in view at the bottom of the page and overlaps the right end of that border.What
Feedback in the article column
The feedback rule in
api-docs.cssplaces the prompt in column 1 instead of1 / -1, still in row 2. The rail occupies row 1 only, so row 1 is at least as tall as the rail. The prompt therefore still starts below the rail, which keeps the behaviour from #4525. Below 1024px the grid has one column and nothing changes.Verify
Open an API group page and an API operation page at a width of 1024px or more, then scroll to the bottom. The border above the prompt ends at the article's right edge.
Check on the preview