Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pages navigation #447

Merged
merged 12 commits into from
Feb 11, 2025
Merged

Add pages navigation #447

merged 12 commits into from
Feb 11, 2025
+406 −123

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 7, 2025 •
edited
Loading

Changes

Add the pages navigation (left sidebar)

Features:

  • Feels like a SPA
    • Scroll Position stays the same when clicking through the navigation items
    • State of collapsed/expanded groups stays while changing pages
  • Almost pure css implementation
    • only rehydrating the state between page navigations uses JS
  • Scroll to current navigation item (if it's not in the viewport)
  • Progressive Enhancement
    • The navigation works also without javascript
    • But the experience is enhanced, if javascript is enabled.

Result

cursorful-video-1739178068485.mp4

@reakaleek reakaleek added the redesign enable redesign feature flag label Feb 7, 2025
@reakaleek reakaleek requested a review from a team February 7, 2025 15:45
@reakaleek reakaleek self-assigned this Feb 7, 2025
@reakaleek reakaleek marked this pull request as draft February 7, 2025 15:55
Base automatically changed from feature/header-searchbar to main February 10, 2025 12:52
@reakaleek reakaleek marked this pull request as ready for review February 10, 2025 21:43
@reakaleek reakaleek requested a review from Mpdreamz February 11, 2025 08:23
Mpdreamz
Mpdreamz approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have sworn I LGTM'd this before 💯

@reakaleek reakaleek merged commit aa8f418 into main Feb 11, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/navigation branch February 11, 2025 09:57
This was referenced Feb 13, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels
redesign enable redesign feature flag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reakaleek @Mpdreamz