Make comment-on-asciidoc-changes.yml scarier #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
reviewed
Feb 7, 2025
Comment on lines
40
to
41
| > [!WARNING] | ||
| > It looks like this PR modifies one or more `.asciidoc` files. These files are being migrated to Markdown, and any changes merged now will be lost. See the [migration guide](https://elastic.github.io/docs-builder/migration/freeze/index.html) for details. |
There was a problem hiding this comment.
Wondering if this needs a bit more indentation
reakaleek
requested changes
Feb 7, 2025
Comment on lines
40
to
41
| > [!WARNING] | ||
| > It looks like this PR modifies one or more `.asciidoc` files. These files are being migrated to Markdown, and any changes merged now will be lost. See the [migration guide](https://elastic.github.io/docs-builder/migration/freeze/index.html) for details. |
There was a problem hiding this comment.
ah wait this is javascript within yaml
reakaleek
reviewed
Feb 7, 2025
Co-authored-by: Jan Calanog <[email protected]>
reakaleek
approved these changes
Feb 7, 2025
reakaleek
reviewed
Feb 7, 2025
Co-authored-by: Jan Calanog <[email protected]>
reakaleek
approved these changes
Feb 7, 2025
|
Tested this works as expected: elastic/elasticsearch#122030 (comment) Thanks @reakaleek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment is currently a little understated :)
(I think the syntax is correct in the yml)
Warning
It looks like this PR modifies one or more
.asciidocfiles. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.