Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign: Add header and breadcrumbs #436

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 6, 2025

Changes

  • Adds initial header and breadcrumbs
  • Add the ability to deploy the preview while activating the redesign feature flag whilst adding the redesign label.

@reakaleek reakaleek added redesign enable redesign feature flag automation packaging, ci/cd. labels Feb 6, 2025
@reakaleek reakaleek marked this pull request as ready for review February 6, 2025 12:29
@reakaleek reakaleek added redesign enable redesign feature flag and removed redesign enable redesign feature flag labels Feb 6, 2025
@bmorelli25
Copy link
Member

This looks so good. Will also close #269.

@reakaleek reakaleek marked this pull request as draft February 6, 2025 14:05
@reakaleek reakaleek added redesign enable redesign feature flag and removed redesign enable redesign feature flag labels Feb 6, 2025
@reakaleek reakaleek mentioned this pull request Feb 6, 2025
@reakaleek reakaleek force-pushed the feature/header-searchbar branch from fa2647d to 35b3859 Compare February 7, 2025 09:17
@reakaleek reakaleek changed the title Add header and searchbar redesign: Add header and breadcrumbs Feb 7, 2025
@reakaleek reakaleek marked this pull request as ready for review February 7, 2025 09:19
@reakaleek reakaleek requested a review from a team February 7, 2025 09:19
@reakaleek reakaleek self-assigned this Feb 7, 2025
@reakaleek reakaleek mentioned this pull request Feb 7, 2025
@@ -66,6 +75,10 @@ jobs:
- name: Bootstrap Action Workspace
if: github.repository == 'elastic/docs-builder' && steps.check-files.outputs.any_changed == 'true'
uses: ./.github/actions/bootstrap

- name: Set REDESIGN feature flag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this.

@reakaleek reakaleek merged commit d6bfa89 into main Feb 10, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/header-searchbar branch February 10, 2025 12:52
@reakaleek reakaleek removed the automation packaging, ci/cd. label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign enable redesign feature flag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants