Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview builds optimizations #407

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Preview builds optimizations #407

merged 1 commit into from
Feb 4, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 4, 2025 •
edited
Loading

Changes

  • workflow_call inputs handling
  • separate pull request data from docs artifacts for fast
  • artifact upload performance tweaks

@reakaleek reakaleek changed the title Various optimizations Preview builds optimizations Feb 4, 2025
@reakaleek reakaleek force-pushed the feature/optimize-preview branch from e049306 to 51b1ea3 Compare February 4, 2025 09:49
@reakaleek reakaleek requested a review from a team February 4, 2025 09:49
@reakaleek reakaleek marked this pull request as ready for review February 4, 2025 09:49
Mpdreamz
Mpdreamz approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what are the current upload times for e.g docs-content or elasticsearch.md ?

Mpdreamz
Mpdreamz reviewed Feb 4, 2025
View reviewed changes
.github/workflows/preview-build.yml
- uses: actions/upload-artifact@v4
with:
name: docs
path: .artifacts/docs/html/
if-no-files-found: error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ this has bit me before :)

@reakaleek
Copy link
Member Author

reakaleek commented Feb 4, 2025 •
edited
Loading

LGTM, what are the current upload times for e.g docs-content or elasticsearch.md ?

Let's see! I will merge this and create a PR in docs-content.

Generally, when I tested it yesterday, it added roughly 1 minute.

@reakaleek reakaleek merged commit 4b7e1c4 into main Feb 4, 2025
5 of 6 checks passed
@reakaleek reakaleek deleted the feature/optimize-preview branch February 4, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reakaleek @Mpdreamz