Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit continue-on-error input to the preview workflow #393

Merged
merged 1 commit into from
Feb 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
workflow_call:
inputs:
strict:
description: 'Treat warnings as errors'
type: boolean
default: true
continue-on-error:
description: 'Do not fail to publish if build fails'
type: boolean
required: false
default: true # default for will be false after migration

permissions:
id-token: write
Expand Down Expand Up @@ -62,7 +68,7 @@ jobs:
- name: Build documentation
if: github.repository != 'elastic/docs-builder'
uses: elastic/docs-builder@main
continue-on-error: ${{ inputs.strict != 'true' }} # Will be removed after the migration phase
continue-on-error: ${{ inputs.continue-on-error == 'true' }} # Will be removed after the migration phase
with:
prefix: "/${{ github.repository }}/pull/${{ github.event.pull_request.number }}"
strict: ${{ inputs.strict }}
Expand Down
2 changes: 1 addition & 1 deletion actions/publish/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ inputs:
description: 'Treat warnings as errors'
required: false
continue-on-error:
description: 'Treat warnings as errors'
description: 'Do not fail to publish if build fails'
required: false
default: "false"
private:
Expand Down