Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redesign feature flag #392

Merged
merged 8 commits into from
Feb 3, 2025
Merged

Add redesign feature flag #392

merged 8 commits into from
Feb 3, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 1, 2025 •
edited
Loading

Changes

  • Set up tailwind
  • Add a "REDESIGN" feature flag
  • Add basic layout when the "REDESIGN" flag is enabled
  • Set up hljs

Notes

You can enable the feature flag if you set the environment variable REDESIGN=true

e.g.

REDESIGN=true ./build.sh watch

Result

image

@reakaleek reakaleek marked this pull request as ready for review February 2, 2025 00:27
@reakaleek reakaleek marked this pull request as draft February 2, 2025 00:27
@reakaleek reakaleek changed the title Set up tailwindcss Add redesign feature flag Feb 3, 2025
@reakaleek reakaleek requested a review from a team February 3, 2025 08:23
@reakaleek reakaleek self-assigned this Feb 3, 2025
@reakaleek reakaleek marked this pull request as ready for review February 3, 2025 08:27
reakaleek
reakaleek commented Feb 3, 2025
View reviewed changes
src/Elastic.Markdown/Slices/Layout/_Head.cshtml
Comment on lines +10 to +18
<link rel="stylesheet" type="text/css" href="@Model.Static("pygments.css")"/>
<link rel="stylesheet" type="text/css" href="@Model.Static("shibuya.css")"/>
<link rel="stylesheet" type="text/css" href="@Model.Static("mystnb.css")"/>
<link rel="stylesheet" type="text/css" href="@Model.Static("copybutton.css")"/>
<link rel="stylesheet" type="text/css" href="@Model.Static("togglebutton.css")"/>
<link rel="stylesheet" type="text/css" href="@Model.Static("sphinx-design.min.css")"/>
<link media="print" rel="stylesheet" type="text/css" href="@Model.Static("/_static/print.css")"/>
<link rel="stylesheet" type="text/css" href="@Model.Static("custom.css")"/>
<link rel="stylesheet" type="text/css" href="@Model.Static("atom-one-light.css")"/>
Copy link
Member Author

@reakaleek reakaleek Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting the old css here, so that the parcel setup only has the new styles.

@reakaleek reakaleek mentioned this pull request Feb 3, 2025
Open
16 tasks
Mpdreamz
Mpdreamz requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we just redesign as we go along?

I'm not that keen on having a fork in the road. Since the old design is not released nor was never meant to be released.

I feel confident we get the new design to a good enough state during the freeze. Wdyt?

Mpdreamz
Mpdreamz approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that, We need this flag at least for the short interim period.where we rebuild all the basic functionally.

@reakaleek reakaleek merged commit 29118e1 into main Feb 3, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/tailwind branch February 3, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reakaleek @Mpdreamz