Fix failing test

elastic · Dec 3, 2024 · fada00e · fada00e
1 parent b133b7e
commit fada00e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Elastic.Markdown/Myst/Directives/VersionBlock.cs b/src/Elastic.Markdown/Myst/Directives/VersionBlock.cs
@@ -28,9 +28,8 @@ public override void FinalizeAndValidate(ParserContext context)
 		if (!SemVersion.TryParse(tokens[0], out var version))
 		{
 			var numbers = tokens[0].Split('.', RemoveEmptyEntries);
-			if (numbers.Length != 2 || !SemVersion.TryParse($"{numbers[0]}.{numbers[1]}", out version))
+			if (numbers.Length != 2 || !SemVersion.TryParse($"{numbers[0]}.{numbers[1]}.0", out version))
 				EmitError(context, $"'{tokens[0]}' is not a valid version");
-			return;
 		}
 
 		Version = version;

diff --git a/tests/Elastic.Markdown.Tests/Directives/VersionTests.cs b/tests/Elastic.Markdown.Tests/Directives/VersionTests.cs
@@ -54,7 +54,7 @@ public class VersionDeprectatedTests(ITestOutputHelper output) : VersionTests(ou
 public abstract class VersionValidationTests(ITestOutputHelper output, string version) : DirectiveTest<VersionBlock>(output,
 $$"""
 ```{versionchanged} {{version}} more information
-Version brief summary 
+Version brief summary
 ```
 A regular paragraph.
 """
@@ -64,6 +64,9 @@ public class SimpleVersion(ITestOutputHelper output) : VersionValidationTests(ou
 {
 	[Fact]
 	public void SetsVersion() => Block!.Version.Should().Be(new SemVersion(7, 17, 0));
+
+	[Fact]
+	public void HasNoError() => Collector.Diagnostics.Should().BeEmpty();
 }
 
 public class MajorVersionOnly(ITestOutputHelper output) : VersionValidationTests(output, "8")