Skip to content

tests/kafka: silence errors arounds create and delete topics #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

tests/kafka: silence errors arounds create and delete topics #2237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tests/instrumentation/kafka_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,18 @@
def topics():
topics = ["test", "foo", "bar"]
admin_client = KafkaAdminClient(bootstrap_servers=[f"{KAFKA_HOST}:9092"])
admin_client.create_topics([NewTopic(name, num_partitions=1, replication_factor=1) for name in topics])
# since kafka-python 2.1.0 we started to get failures in create_topics because topics were already there despite
# calls to delete_topics. In the meantime we found a proper fix use a big hammer and catch topics handling failures
# https://github.com/dpkp/kafka-python/issues/2557
try:
admin_client.create_topics([NewTopic(name, num_partitions=1, replication_factor=1) for name in topics])
except Exception:
pass
yield topics
admin_client.delete_topics(topics)
try:
admin_client.delete_topics(topics)
except Exception:
pass


@pytest.fixture()
Expand Down
Loading