Better faces #1040
Open
Better faces #1040
+113
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be a way to attach an edge-length refiner with collapse or subdivide done per polygon. |
pca006132
reviewed
Nov 14, 2024
| Vec<TriPriority> triPriority(numTri); | ||
| for_each_n(autoPolicy(numTri), countAt(0), numTri, | ||
| [&triPriority, this](int tri) { | ||
| meshRelation_.triRef[tri].faceID = -1; |
There was a problem hiding this comment.
Is this causing the check in line 238 and 249 to always be false?
| } else { | ||
| interiorHalfedges.push_back(h); | ||
| } | ||
| const int hNext = NextHalfedge(h); |
There was a problem hiding this comment.
Why are we also working with the front of the queue?
| if (abs(dot(v - base, normal)) < tolerance_) { | ||
| meshRelation_.triRef[h / 3].faceID = tp.tri; | ||
| if (!interiorHalfedges.empty() && | ||
| h == halfedge_[interiorHalfedges.back()].pairedHalfedge) { |
There was a problem hiding this comment.
Considering h = NextHalfedge(halfedge_[interiorHalfedges.back()].pairedHalfedge), will this condition ever hold?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm replacing our
CreateFacesalgorithm. Our previous was based on connected components, but in the case of e.g. a high-res sphere, it would connect everything into one big face. So then we added an algorithm to check global tolerance of each face after the fact, and if that failed, it would just throw out all the faces and say each triangle was individual.This new algorithm skips all that and instead finds faces by starting with the largest triangle and searching its neighbors until none are within tolerance. Then it gets the next largest unprocessed triangle and does it again, serially, until all triangles have been assigned to faces. It's a bit arbitrary, but works decently.
Ideally we can eventually follow this on with some improved edge collapsing code.