Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix atomic exchange template deduction #1035

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

pca006132
Copy link
Collaborator

Fixes #1027.

@fire let me know when you have tested this.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (d437097) to head (b932228).
Report is 145 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
- Coverage   91.84%   85.09%   -6.75%     
==========================================
  Files          37       62      +25     
  Lines        4976     9736    +4760     
  Branches        0     1051    +1051     
==========================================
+ Hits         4570     8285    +3715     
- Misses        406     1451    +1045     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fire
Copy link
Contributor

fire commented Nov 11, 2024

Got your message.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks likely to fix the problem - @fire please reopen the issue if not.

@elalish elalish merged commit 12b43f5 into elalish:master Nov 12, 2024
21 checks passed
@fire
Copy link
Contributor

fire commented Nov 12, 2024

I have tested it, and it fixes my issue. @pca006132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no matching function for call to 'atomic_exchange' in manifold/src/properties.cpp:89:18
3 participants