add signal builders interface #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekiwi
requested changes
Oct 29, 2024
There was a problem hiding this comment.
This looks great! However, I would like to simplify the review. Since you yourself already indicated that the Rust stuff isn't quite done, how about you isolate all the changes that are necessary for the functionality demonstrated in the Python test_slice() function and make a PR with that. Then we can discuss and work on the Rust stuff as a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a first pass PR at adding "derived" signals in a fairly well defined way, in both python and rust
in python, we have a working test for the "slice" case -- while we could support this with custom code in rust, i think its a decent exercise for showing how we can use python logic to create a new signal
in rust, we have a bunch of unused code -- the
SimpleLazyexample is unused in tests, and the ClockedSignal has an ignored test that isnt fully implemented.overall, i think the python code is in a much better state than the rust code (the test isn't fully implemented), and if we want to merge it quickly then we should probably remove the
derived_signalsrust code for nowlook at the tests for examples of these apis