-
Notifications
You must be signed in to change notification settings - Fork 2
chore: keeping project up to date #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| export DIRENV_WARN_TIMEOUT=20s | ||
|
|
||
| eval "$(devenv direnvrc)" | ||
|
|
||
| # `use devenv` supports the same options as the `devenv shell` command. | ||
| # | ||
| # To silence all output, use `--quiet`. | ||
| # | ||
| # Example usage: use devenv --quiet --impure --option services.postgres.enable:bool true | ||
| use devenv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,125 +1,19 @@ | ||
| version: "2" | ||
|
|
||
| run: | ||
| timeout: 5m | ||
| issues-exit-code: 1 | ||
| tests: false | ||
| modules-download-mode: readonly | ||
| allow-parallel-runners: true | ||
|
|
||
| output: | ||
| print-issued-lines: true | ||
| print-linter-name: true | ||
|
|
||
| linters: | ||
| disable: | ||
| - depguard | ||
| - exhaustruct | ||
| - fatcontext | ||
| - gochecknoglobals | ||
| - goconst | ||
| - godot | ||
| - godox | ||
| - nonamedreturns | ||
| - nlreturn | ||
| - varnamelen | ||
| - inamedparam | ||
| - wsl | ||
| - wrapcheck | ||
| presets: | ||
| - bugs | ||
| - comment | ||
| - complexity | ||
| - error | ||
| - format | ||
| - import | ||
| - metalinter | ||
| - module | ||
| - performance | ||
| - style | ||
| - test | ||
| - unused | ||
|
|
||
| linters-settings: | ||
| exhaustive: | ||
| ignore-enum-members: '^*(Unspecified|Undefined|Unknown|Idle)$' | ||
| cyclop: | ||
| max-complexity: 20 | ||
| gomnd: | ||
| ignored-numbers: | ||
| - '2' | ||
| - '4' | ||
| - '8' | ||
| - '16' | ||
| - '32' | ||
| - '64' | ||
| gci: | ||
| sections: | ||
| - standard # Standard section: captures all standard packages. | ||
| - default # Default section: contains all imports that could not be matched to another section type. | ||
| - prefix(github.com/einouqo/ext-kit) # Custom section: groups all imports with the specified Prefix. | ||
| - blank # Blank section: contains all blank imports. This section is not present unless explicitly enabled. | ||
| - dot | ||
| tagliatelle: | ||
| case: | ||
| rules: | ||
| json: snake | ||
| yaml: snake | ||
| exclusions: | ||
| rules: | ||
| # an exception, as the error value is used to signal the end of the stream | ||
| - linters: | ||
| - staticcheck | ||
| source: "StreamDone" | ||
| # as documentation states: "... This method always returns a nil error" https://github.com/grpc/grpc-go/blob/v1.78.0/stream.go#L105-L108 | ||
| - linters: | ||
| - errcheck | ||
| source: "defer .*\\.CloseSend()" | ||
|
|
||
| issues: | ||
| exclude-dirs: | ||
| - test # no lints for tests | ||
| exclude-files: | ||
| - .*_test.go$ # unit tests | ||
| - transport/ws/intercepting_writer.go # code from http package of go-kit project (https://github.com/go-kit/kit/blob/master/transport/http/intercepting_writer.go). | ||
| exclude-rules: | ||
| - linters: | ||
| - wrapcheck | ||
| text: 'error returned from interface method should be wrapped' | ||
| source: ^*return .* | ||
| - linters: | ||
| - wrapcheck | ||
| text: ^error returned from external package is unwrapped[:] .*multierror.* error$ | ||
| - linters: | ||
| - wrapcheck | ||
| source: .*status.Error\(.*, .*\).* | ||
| - linters: | ||
| - cyclop | ||
| text: 'calculated cyclomatic complexity for function' | ||
| source: ^func \(.*\) String\(\) string {$ | ||
| - linters: | ||
| - gomnd | ||
| source: .*(time\..|[0-9]+<<[0-9]+)*$ | ||
| - linters: | ||
| - gofumpt | ||
| source: ^var \( | ||
| - linters: | ||
| - unparam | ||
| # except setters with self returning | ||
| text: .*\)\.set([A-z0-9]+)? - result 0 \(\*.*\) is never used$ | ||
| - linters: | ||
| - gosec | ||
| text: 'G109:' | ||
| - linters: | ||
| - gosec | ||
| text: 'G404:' | ||
| - linters: | ||
| - lll | ||
| source: .*// .* | ||
| - linters: | ||
| - stylecheck | ||
| text: 'ST1012:' | ||
| - linters: | ||
| - forbidigo | ||
| text: use of `fmt\..*` forbidden by pattern `.*`$ | ||
| - path: transport # ok for transport | ||
| linters: [ gocognit, gocyclo, cyclop, forcetypeassert, funlen, ireturn, lll ] | ||
| - path: endpoint | ||
| linters: [ errname, revive ] | ||
| - linters: | ||
| - gocritic | ||
| text: 'appendAssign: append result not assigned to the same slice' | ||
| - linters: | ||
| - errcheck | ||
| source: ^\s*defer .*$ | ||
| - linters: | ||
| - revive | ||
| text: 'if-return: redundant if ...;' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .golangci.yml config has been dramatically simplified from a comprehensive configuration to minimal exclusions. While this may be intentional, it removes all linter presets, custom settings, and most exclusion rules that were previously in place. This could lead to many new linting errors appearing. Consider whether this level of simplification is intended, or if key configurations should be retained.