Skip to content

Improving ottomata's approach to add optional response headers#29

Open
rcarubbi wants to merge 4 commits intoeinaros:masterfrom
rcarubbi:master
Open

Improving ottomata's approach to add optional response headers#29
rcarubbi wants to merge 4 commits intoeinaros:masterfrom
rcarubbi:master

Conversation

@rcarubbi
Copy link

This change allows to add response headers from SSE constructor like this:

var sse = new SSE(server, { headers: { 'Access-Control-Allow-Origin': '*', "Access-Control-Allow-Headers": "Origin, X-Requested-With, Content-Type, Accept, x-access-token", "Access-Control-Allow-Methods": "GET, POST, PUT, DELETE, OPTIONS" } });

@rcarubbi
Copy link
Author

I created other pull request but after study ottomata's approach I decided to use that. But when I was trying to use I realize that is not possible to use from SSE constructor. So I created another pull request.

@akodate
Copy link

akodate commented May 17, 2019

Hey @rcarubbi I just wanted to say that this is a very useful pull request (which I'm going to fork and use in my work) and I hope it gets merged at some point. Thanks for creating it.

@rcarubbi
Copy link
Author

rcarubbi commented May 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants