Improving ottomata's approach to add optional response headers#29
Open
rcarubbi wants to merge 4 commits intoeinaros:masterfrom
Open
Improving ottomata's approach to add optional response headers#29rcarubbi wants to merge 4 commits intoeinaros:masterfrom
rcarubbi wants to merge 4 commits intoeinaros:masterfrom
Conversation
Author
|
I created other pull request but after study ottomata's approach I decided to use that. But when I was trying to use I realize that is not possible to use from SSE constructor. So I created another pull request. |
|
Hey @rcarubbi I just wanted to say that this is a very useful pull request (which I'm going to fork and use in my work) and I hope it gets merged at some point. Thanks for creating it. |
Author
|
Hi,
I really appreciate your comment and I'm glad it was useful for you.
Regards
Em sex, 17 de mai de 2019 13:06, Alex <notifications@github.com> escreveu:
… Hey @rcarubbi <https://github.com/rcarubbi> I just wanted to say that
this is a very useful pull request (which I'm going to fork and use in my
work) and I hope it gets merged at some point. Thanks for creating it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29?email_source=notifications&email_token=AAITSFHCGWCQ6P4DI3L5HV3PV3JZJA5CNFSM4EWEFH2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVFSMQ#issuecomment-493508914>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAITSFB76KTXHJ7CPHEGEEDPV3JZJANCNFSM4EWEFH2A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to add response headers from SSE constructor like this:
var sse = new SSE(server, { headers: { 'Access-Control-Allow-Origin': '*', "Access-Control-Allow-Headers": "Origin, X-Requested-With, Content-Type, Accept, x-access-token", "Access-Control-Allow-Methods": "GET, POST, PUT, DELETE, OPTIONS" } });