feat: ampd deployment k8s #16
Conversation
It will try to build the ampd binary periodically. We have some git dependencies without version fixing and that we want to maintain in that way because we are still adjusting many things and we want it to be "liquid".
eloylp
force-pushed
the
ampd-deployment-k8s
branch
from
b727d71
to
5a1809b
Compare
| @@ -273,7 +273,7 @@ mod test { | |||
| let expiration = 100u64; | |||
| let (_, rx) = watch::channel(expiration - 1); | |||
| let source_chain = ChainName::from_str("solana").unwrap(); | |||
| let poll_started_source_chain = ChainName::from_str("other_chain").unwrap(); // A different, unexpected source chain. | |||
| let poll_started_source_chain = ChainName::from_str("otherchain").unwrap(); // A different, unexpected source chain. | |||
There was a problem hiding this comment.
Looks like some validations are taking place now in the axelar codebase.
| })) => axelar_message_primitives::command::Operators::new( | ||
| operators, | ||
| weights.into_iter().map(axelar_message_primitives::command::U256::from).collect(), | ||
| axelar_message_primitives::command::U256::from(quorum), |
There was a problem hiding this comment.
I am mapping the threshold with the quorum, but unsure if we are talking about the same thing.
There was a problem hiding this comment.
yes, they are the same thing 👍
| @@ -208,21 +217,7 @@ where | |||
| } | |||
| }; | |||
|
|
|||
| let account_data = match self.rpc_client.get_account_data(&pub_key).await { | |||
There was a problem hiding this comment.
seems (if this is correct) we already have all needed information coming from the initial Solana tx for verifying the workerset. So we can remove the extra RPC call to fetch the account data.
| @@ -172,7 +175,6 @@ mod tests { | |||
| let payload_hash: [u8; 32] = [0; 32]; | |||
| let source_gateway_address: String = "sol_gateway_addr".to_string(); | |||
| let source_pubkey = Pubkey::from([0; 32]); | |||
| let source_address = PubkeyWrapper::from(source_pubkey); | |||
There was a problem hiding this comment.
No more PubkeyWrapper anymore only Pubkey
| # shared-key: "ampd" | ||
|
|
||
| - name: Build the code | ||
| run: cd ampd && cargo build |
There was a problem hiding this comment.
This should be removed, as we are implementing it in https://github.com/eigerco/solana-axelar-internal/issues/344
Referenced Issue
https://github.com/eigerco/solana-axelar/issues/220
Description
This PR adds a CI workflow that:
ampddaemon.TODO
Add SSH auth, so we can pull the private dependencies like gmp-gateway.no need. Theaxelar-solanarepo is now public.