Port the Pivot Slide feature of the legacy Rigify spine to super_spine. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pivot Slide seems to be the largest feature that was lost when merging original and PitchiPoy rigs to form the new rig set. This ports it as an option in the new spine rig, thus making the legacy spine completely obsolete. When not enabled, the generated rig shouldn't change. Also, head/tail and tweaks should work the same even with the dynamic pivot mode. The code is directly based on the legacy implementation, but extensively edited to make it fit into super_spine code.
The way they were just dangling off tweak bones just made no sense. If the neck is long, ORG bones are used for IK, so it's unchanged.
|
So I've been thinking whether it's actually such a good idea to merge head, tail and spine in one monolithic rig. This makes it really hard for someone to change just one component of this combination. Maybe this should be refactored to be more modular, so that it's at least possible to do that in a reasonable way by inheriting from this spine rig?.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for another pull request in such a short time, but this is what I really wanted to do after some practice with fingers. Basically the idea is to make the legacy spine completely obsolete by porting its biggest feature to the new spine rig as an option, while integrating it with the new features. Since I'm not an animator I can't evaluate how actually useful it is in real practice, but I want to keep @cessen's invention alive :)
I also fix nonsensical disjoint ORG bone positions when you move the tweak bones.
Rig diagram: https://www.dropbox.com/s/vfjjkzgzfke2vt7/rigify-new-spine4b.svg?dl=0