Skip to content

Update the branch with changes from upstream 2.8 master. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: rigify_0.6_beta
Choose a base branch
from
Open

Update the branch with changes from upstream 2.8 master. #14

wants to merge 4 commits into from

Conversation

angavrilov
Copy link

This includes changes that have already been committed to the upstream 2.8 addons repository.

  • Fix: RigifyParameters is cleared when toggling legacy mode to shut up warnings in the console.
  • Fix: Bend Hint wording mismatch is fixed to shut up warnings.
  • Updates the Feature Set patches with tweaks done before committing to upstream, including a fix for broken "Add Sample" UI.
  • Rigs are modified to use the new make_property utility function (back-portable part of a 2.8 API compatibility update commit). Custom properties created without the use of that function will be defective in 2.8.

@angavrilov
Rigify: clear RigifyParameters properties when toggling legacy mode.
f605ae6 
Registering and unregistering the class causes 2.8 to complain
about non-annotation properties, and this avoids the problem.
Plus, legacy and non-legacy shouldn't interact.

The 'make annotation' spam also happens on addon enable
toggle, so apply the legacy toggle fix globally.
@angavrilov
Tweaks committed to upstream with the D4364 patch.
6803d1a
@angavrilov
Unify wording of the Bend Hint parameter in legacy rigs.
f0d224f 
RigifyParameterValidator doesn't like the difference.
@angavrilov
Rigify: prepare to set custom property defaults and overridable flags.
59329d3 
In 2.8 custom property creation becomes more complex, with the
need to set a default value for correct NLA blending and an
overridable flag for static overrides. The most logical way
to do that is to refactor rigs to use the new make_property
utility, and implement the new features there.

This backports all those changes minus the actual new features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@angavrilov