Skip to content

Add track-protocluster link #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ruse-traveler
Copy link
Contributor

@ruse-traveler ruse-traveler commented Apr 22, 2025

Briefly, what does this PR introduce?

This PR introduces the edm4eic::TrackProtoClusterLink, a parallel to the existing edm4eic::TrackClusterMatch. This functionality was identified as missing during discussion of EICrecon#1669: in order to ensure that merged/split clusters are reconstructed consistently with other clusters it's preferable for the TrackClusterMergeSplitter to output edm4eic::ProtoClusters, but the connections between the merged/split protoclusters and their antecedent tracks will need to be propagated to downstream particle flow algorithms. This new type will facilitate this.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@ruse-traveler ruse-traveler requested a review from a team as a code owner April 22, 2025 18:50
@ruse-traveler ruse-traveler changed the title Add track-protocluster match Add track-protocluster link May 1, 2025
@veprbl
Copy link
Member

veprbl commented May 1, 2025

This needs https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/1135

Translates to include/edm4eic/TrackProtoClusterLinkCollection.h

// AUTOMATICALLY GENERATED FILE - DO NOT EDIT

#ifndef EDM4EIC_TrackProtoClusterLinkCollection_H
#define EDM4EIC_TrackProtoClusterLinkCollection_H

#include "edm4eic/TrackCollection.h"
#include "edm4eic/ProtoClusterCollection.h"

#include <podio/LinkCollection.h>

namespace edm4eic {

using TrackProtoClusterLinkCollection = podio::LinkCollection<::edm4eic::Track, ::edm4eic::ProtoCluster>;
using TrackProtoClusterLink = typename TrackProtoClusterLinkCollection::value_type;
using MutableTrackProtoClusterLink = typename TrackProtoClusterLinkCollection::mutable_type;

} // namespace edm4eic


#endif

@veprbl veprbl requested a review from sly2j May 1, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants