Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation - by @Marc-R2 #137

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

Marc-R2
Copy link
Contributor

@Marc-R2 Marc-R2 commented Sep 29, 2024

Add german translation de-de.json

@eibex
Copy link
Owner

eibex commented Sep 29, 2024

Hi! Thanks for the PR.
There are a few errors that must be fixed before we can merge it. Discord has a character limit for both messages and modals (modals/cmd descriptions are particularly strict since they max out at 100 characters).
The following strings need to be fixed:
brief-settings-notify: must be 100 or less characters (now it's 148)
brief-settings-systemchannel: must be 100 or less characters (now it's 106)
message-reaction-option-channel: must be 100 or less characters (now it's 105)
message-reaction-option-action: must be 100 or less characters (now it's 105)
settings-systemchannel-option-type: must be 100 or less characters (now it's 112)
settings-activity-option-action: must be 100 or less characters (now it's 104)
settings-activity-option-activity: must be 100 or less characters (now it's 105)

fix(msg too long):
for
- brief-settings-notify: must be 100 or less characters (was 148)
- brief-settings-systemchannel: must be 100 or less characters (was 106)
- message-reaction-option-channel: must be 100 or less characters (was 105)
- message-reaction-option-action: must be 100 or less characters (was 105)
- settings-systemchannel-option-type: must be 100 or less characters (was 112)
- settings-activity-option-action: must be 100 or less characters (was 104)
- settings-activity-option-activity: must be 100 or less characters (was 105)
@Marc-R2
Copy link
Contributor Author

Marc-R2 commented Sep 30, 2024

Oh, I didn't know that. I have corrected the mentioned lines.

@eibex
Copy link
Owner

eibex commented Sep 30, 2024

Thanks!

@eibex eibex merged commit 289306f into eibex:master Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants