Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #27 - proposal to shift anchors #39

Closed
wants to merge 1 commit into from
Closed

Issue #27 - proposal to shift anchors #39

wants to merge 1 commit into from

Conversation

mathieucarbou
Copy link
Member

@mathieucarbou mathieucarbou commented Apr 19, 2016

proposal to shift anchors to not hide the top of the scrolled-to sections.

This fix changes:

<h3 id="code-cache-code-elements”>
    <a class="anchor" href="#code-cache-code-elements"></a>
    <code>&lt;cache&gt;</code> elements
</h3>

to:

<h3>
    <a class="anchor" name="code-cache-code-elements" id="code-cache-code-elements"></a>
    <code>&lt;cache&gt;</code> elements
</h3>

and also applies a CSS to shift the anchor <a name...> 70px above the section, to account for the floating banner.

This solves issue #27 and is compatible with normal anchors like we have in the documentation page at http://localhost:4000/documentation/#historical_versions

The real fix would be to control the asciidoc generation though...

@mathieucarbou
Copy link
Member Author

@ljacomet : rebased!

@boyusun
Copy link

boyusun commented Sep 29, 2016

I just realize this pr is the same as the pr I just created: #92. If possible, please refer to my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants