This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Audit Report Bug Fixes #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather than report endpoint and therefore failing. Additionally, when an audit report is successfully deleted it returns a 204 status (i.e. no content) and the check_response function fails if the status is not 200 so also added no content as a valid HTTP response.
|
Why was this never merged? |
|
No idea unfortunately, never got a response after putting up the pull request. Not looked at the API recently so don’t know if it’s changed, but feel free to use the changes. |
|
Did you ever end up integrating with Egnyte? What was your experience? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not delete audit reports via the python SDK for two reasons:
I have implemented fixes to both functions. Would advise a wider catch on HTTP status codes to include all 2XX codes.