use rowMeans for polyphonic playback

[egenn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @egenn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the audio processing for polyphonic playback by adjusting how individual sound waves are combined. The change from summing to averaging the waves aims to improve the overall sound quality and prevent audio distortion, particularly when multiple notes are played concurrently. This is a targeted improvement to the playWave function's handling of multi-note scenarios.

Highlights

• Polyphonic Playback Logic: The core logic for combining multiple sound waves in polyphonic playback has been updated. Previously, rowSums was used to sum the waves, which could lead to clipping or excessive volume when multiple notes played simultaneously. This has been changed to rowMeans, ensuring that the combined wave's amplitude is averaged, providing a more balanced and potentially clearer audio output.
• Metadata Update: The copyright year in the R/play.R file header has been updated from '2019-' to '2019-present' to reflect ongoing development.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request changes the audio mixing strategy to prevent audio clipping during polyphonic playback. A code comment is suggested to document the volume reduction side-effect.

[gemini-code-assist]

Using rowMeans prevents audio clipping but reduces overall volume as more notes are added. Add a comment explaining this trade-off.

    # Average waves to prevent clipping; reduces overall volume as more notes are added.
    wave <- rowMeans(wave)