Skip to content

Free leaked memory in libhrd_cpp #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kristianmitk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Free leaked memory in libhrd_cpp #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7481d26
free definitely lost memory from libhrd_cpp
kristianmitk Feb 18, 2020
db40d72
remove duplicate memcached_create(nullptr) call
kristianmitk Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libhrd_cpp/hrd_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ void hrd_get_formatted_time(char* timebuf) {

memcached_st* hrd_create_memc() {
memcached_server_st* servers = nullptr;
memcached_st* memc = memcached_create(nullptr);
memcached_st* memc = nullptr;
memcached_return rc;

memc = memcached_create(nullptr);
Expand All @@ -331,6 +331,7 @@ memcached_st* hrd_create_memc() {
rc = memcached_server_push(memc, servers);
rt_assert(rc == MEMCACHED_SUCCESS, "Couldn't add memcached server");

memcached_server_list_free(servers);
return memc;
}

Expand Down Expand Up @@ -429,10 +430,12 @@ void hrd_wait_till_ready(const char* qp_name) {
tries++;
if (ret > 0) {
if (strcmp(value, exp_value) == 0) {
free(value);
return;
}
}

free(value);
usleep(200000);

if (tries > 100) {
Expand Down