JS: Strip trailing/leading whitespace in externs (+ warn) #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
reviewed
Sep 11, 2024
| val end = l.last | ||
| val mid = l.tail.init | ||
| if (start.matches("""^\s.*""") || end.matches(""".*\s$""")) { | ||
| Context.warning("Extern string in js has trailing / leading whitespace. This will be removed.") |
There was a problem hiding this comment.
I think this warning can be very annoying, no?
There was a problem hiding this comment.
It could be - we're not using it anywhere yet, so...
I can also remove it.
There was a problem hiding this comment.
I think this is the perfect place for a warning, tbh. It will fire only on new code that is potentially problematic. :)
marzipankaiser
force-pushed
the
fix/issue569
branch
from
3d47570 to
4b125b1
Compare
jiribenes
force-pushed
the
master
branch
3 times, most recently
from
ee9d209 to
58c8510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569.
This basically applies this suggestion: #569 (comment)
but generates a warning instead of an error.
We do not seem to use this anywhere.