Stdlib: Add OneOrBoth and zipLongest on lists and streams
#1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
reviewed
May 19, 2025
libraries/common/list.effekt
Outdated
| /// ``` | ||
| /// | ||
| /// O(N) | ||
| def zipLongest[A, B](left: List[A], right: List[B]): List[These[A, B]] = { |
There was a problem hiding this comment.
Bikeshed: Unison calls this align which is a bit nicer, perhaps?
(ditto for streams)
There was a problem hiding this comment.
Here I care more about the name. Honestly, I would not search for this under the name align and don't quite get how this describes the operation well. align is a single word, but I fail to see how this fits the semantics uniquely.
There was a problem hiding this comment.
Funnily enough align is the name used in Haskell :D
https://hackage.haskell.org/package/semialign-1.3.1/docs/Data-Align.html#v:align
There was a problem hiding this comment.
We could also "just" call it zip and rely on the overload resolution ;)
jiribenes
reviewed
May 19, 2025
jiribenes
reviewed
May 19, 2025
Co-authored-by: Jiří Beneš <[email protected]>
marzipankaiser
changed the title
These and zipLongest on lists and streamsOneOrBoth and zipLongest on lists and streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.