making use of from_cell_with_material#7
Open
shimwell wants to merge 2 commits intoeepeterson:r2s_model_wrapperfrom
Open
making use of from_cell_with_material#7shimwell wants to merge 2 commits intoeepeterson:r2s_model_wrapperfrom
shimwell wants to merge 2 commits intoeepeterson:r2s_model_wrapperfrom
Conversation
shimwell
commented
Feb 1, 2023
eepeterson
pushed a commit
that referenced
this pull request
Mar 23, 2023
Update IO format docs for meshes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress, this won't work yet but nice to see the potential improvements
I think the r2smodel can be simplified by making use of the open PR that adds
from_cell_with_materialclass method.Additionally this makes sure the source points are born within the cell which is a small improvement on the current version that makes sure the source points are created withing the cell bounding box
note to self, check if the cell needs the material setting to an entry in new_mats