Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Added complete license text #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shivanshuraj1333
Copy link
Contributor

@shivanshuraj1333 shivanshuraj1333 commented Mar 29, 2019

**Fixes #47 **
In this pull request I added License text of all the licenses available at https://spdx.org/licenses/
Also I sorted list of License in alphabetical order.
-> New License Description page
new_clio

-> Old License Description page
old_clio

@zvr
Copy link
Collaborator

zvr commented Mar 29, 2019

Thanks.
But this list also includes deprecated licenses. Before including them, it would be better to have conclusion on how extra information on licenses will be handled -- which is is kind of what #39 is all about.

@zvr
Copy link
Collaborator

zvr commented Mar 29, 2019

Also I'm not sure a huge .csv file is the correct way to have all the data...

@shivanshuraj1333
Copy link
Contributor Author

Okay,

  • For now let me remove deprecated licenses.
  • @zvr I don't think large .csv file will create any issue. (infact populate_db.py takes less than 1 minute to populate database after this fix commit the changes to DB only once it's populated #43 (thanks to you))
  • Advantage of using .csv file is that anyone can populate database without internet connectivity. (there are other options to populate database but they will require internet connectivity)
  • Once there has to be way to use a newer version of the license list #39 is solved, data handling will be much better but this csv file will be needed to initially populate database with license text info. So, this pull request needs to be get merged.

@shivanshuraj1333
Copy link
Contributor Author

Okay,

  • For now let me remove deprecated licenses.
  • @zvr I don't think large .csv file will create any issue. (infact populate_db.py takes less than 1 minute to populate database after this fix commit the changes to DB only once it's populated #43 (thanks to you))
  • Advantage of using .csv file is that anyone can populate database without internet connectivity. (there are other options to populate database but they will require internet connectivity)
  • Once there has to be way to use a newer version of the license list #39 is solved, data handling will be much better but this csv file will be needed to initially populate database with license text info. So, this pull request needs to be get merged.

@zvr please review this PR and if there is any issue (besides csv size) is left, please let me know. The csv file is created from https://github.com/spdx/license-list-data and contains complete data.

@shivanshuraj1333
Copy link
Contributor Author

Link to my script to generate csv (with lic. text).
Clone https://github.com/spdx/license-list-data and in same directory run myscript

@shivanshuraj1333
Copy link
Contributor Author

If it was created, we need the software that created it, for review. But we shouldn't be transforming the data in other formats...

@zvr please review this. I wrote another script which will use upstream data directly to populate database solving #52.
Note: Both (this and new script) uses original data extracted from https://github.com/spdx/license-list-data

@zvr
Copy link
Collaborator

zvr commented Apr 2, 2019

I have made comments about the update script in #53; same apply here.

@shivanshuraj1333
Copy link
Contributor Author

Updated .csv file from latest license release by SPDX. This is the link to my gist for generating csv file for every new release of licenses by SDPX.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants