Skip to content

fix: Updating check python dependencies for setuptools #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktyagiapphelix2u wants to merge 4 commits into
base: release-ulmo
Choose a base branch
from
Open

fix: Updating check python dependencies for setuptools #116

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bad8f7a
fix: Updating check python dependencies for setuptools
ktyagiapphelix2u Feb 10, 2026
8ce3ce1
fix: Updating check python dependencies for setuptools
ktyagiapphelix2u Feb 10, 2026
fd1e2b9
fix: Updating check python dependencies for setuptools
ktyagiapphelix2u Feb 10, 2026
5433e5a
fix: Updating check python dependencies for setuptools
ktyagiapphelix2u Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/check_python_dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Upgrade pip and setuptools
run: python -m pip install --upgrade pip setuptools
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow installs the latest pip/setuptools via --upgrade, which bypasses the repo’s pinned toolchain in requirements/pip.txt (e.g., pip==25.2, setuptools==80.9.0). Using unpinned latest versions can make CI nondeterministic or break unexpectedly. Consider installing from requirements/pip.txt (and include wheel if needed) to keep this workflow consistent with the other Python workflows.

Suggested change
- name: Upgrade pip and setuptools
run: python -m pip install --upgrade pip setuptools
- name: Install pinned Python packaging tools
run: python -m pip install -r requirements/pip.txt

Copilot uses AI. Check for mistakes.

- name: Install repo-tools
run: pip install edx-repo-tools[find_dependencies]

- name: Install setuptool
run: pip install setuptools

- name: Run Python script
run: |
find_python_dependencies \
Expand Down
Loading