Skip to content

chore: harden repo hygiene#1170

Closed
dragonnite1221-lgtm wants to merge 6 commits into
edwardkim:develfrom
dragonnite1221-lgtm:public/repo-hygiene-devel
Closed

chore: harden repo hygiene#1170
dragonnite1221-lgtm wants to merge 6 commits into
edwardkim:develfrom
dragonnite1221-lgtm:public/repo-hygiene-devel

Conversation

@dragonnite1221-lgtm

Copy link
Copy Markdown
Contributor

Summary

  • remove tracked local HTTPS certificates and document local cert generation
  • remove the unmaintained paste dependency by replacing identifier concatenation with explicit macro inputs
  • refresh npm lockfiles to keep audits clean
  • apply clippy-only cleanup on current devel

This is the small repo hygiene slice requested in #1169. It intentionally excludes the wasm_api split and HWPX fragment paste feature work.

Validation

  • git diff --check origin/devel...HEAD
  • cargo fmt --all -- --check
  • cargo audit
  • npm audit in rhwp-chrome, rhwp-firefox, rhwp-studio, rhwp-vscode
  • gitleaks detect --no-git --redact --source . --verbose
  • cargo check --target wasm32-unknown-unknown --lib
  • cargo clippy --all-targets -- -D warnings
  • cargo test --all-targets
  • npm run build in rhwp-chrome, rhwp-firefox, rhwp-studio
  • npm run compile in rhwp-vscode
  • graphify update .

@jangster77

jangster77 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

검토해 주셔서 감사합니다.

이 PR은 #1169 후속으로 repo hygiene 범위를 분리해 주신 취지는 이해했습니다. 다만 현재 devel 기준으로는 그대로 병합하기 어렵다고 판단했습니다.

주요 사유는 다음과 같습니다.

  • 현재 PR이 devel과 충돌 상태입니다. 로컬 merge 검증에서도 src/serializer/*, src/wasm_api/tests.rs, tests/svg_snapshot.rs 등에서 conflict가 발생했습니다.
  • PR 제목과 목적은 repo hygiene이지만, 인증서 제거, paste dependency 제거, npm lockfile 갱신 외에 serializer error propagation/refactor까지 함께 포함되어 있어 검토 및 병합 단위가 너무 커졌습니다.
  • PR 작성 및 검증 시점이 오래되어 현재 devel 기준으로 검증 결과를 신뢰하기 어렵습니다.

따라서 이 PR은 여기서 close하겠습니다.

다만 제안해 주신 내용 중 일부는 여전히 유효해 보입니다. 가능하시다면 현재 devel 기준으로 아래처럼 작은 단위의 새 PR로 다시 올려 주시면 검토하겠습니다.

  1. tracked local HTTPS certificate 제거 및 local certificate 생성 문서화
  2. paste dependency 제거
  3. npm lockfile 갱신
  4. serializer error propagation/refactor는 별도 PR로 분리

기여해 주셔서 감사합니다.


Thank you for the contribution.

I understand that this PR was intended to split out the repo-hygiene work after #1169. However, after reviewing it against the current devel branch, I do not think we can merge it as-is.

Main reasons:

  • The branch currently conflicts with devel. A local merge check produced conflicts in src/serializer/*, src/wasm_api/tests.rs, and tests/svg_snapshot.rs.
  • The PR scope is broader than repo hygiene. In addition to local certificate cleanup, paste dependency removal, and npm lockfile refresh, it also includes serializer error propagation/refactor changes.
  • The PR and its validation are now stale relative to the current devel branch.

For that reason, this PR has been closed.

Some parts of the proposal still look useful. If you are still interested, please open fresh, smaller PRs based on the current devel branch:

  1. Remove tracked local HTTPS certificates and document local certificate generation.
  2. Remove the paste dependency, if still applicable.
  3. Refresh npm lockfiles from the current tree.
  4. Submit serializer error propagation/refactor separately, with focused tests.

Thank you again for the contribution.

@jangster77 jangster77 closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants