chore: remove Python reliability scanner findings - #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
math.isnanchecks; no tolerance, epsilon, or approximate comparison was added.Verification
The eight original comparison forms are all absent:
The generated report comparison is empty:
The builder run produced 103264 bytes both before and after, with SHA-256
0fc0b6865d6ed21aef9145906d603b185fdf9181af2dcaf211928c983e6b2a2bboth times.Coverage by changed site
manyvalued.py:tests/test_many_valued_degree_negation_and_implication_are_evaluatedandtests/test_the_degree_of_a_trace_is_the_infimum_of_its_recordspassed. There is no direct test invoking the newly shared Gödel/Product negation helper; the former exercises Łukasiewicz negation and the latter exercises the Gödel trace path without unary negation.conformance.py:tests/test_no_check_scores_a_certificate_that_measured_nothing,tests/test_an_unmeasured_group_never_wins_the_per_group_comparison, andtests/test_coverage_and_fidelity_agree_with_the_certificatepassed. There is no direct NaN/huge-integer test forvalue_measured.statistical.py:tests/test_ratio_enclosure_and_zero_denominator_refusalandtests/test_statistical_numeric_and_refusal_edgespassed; the zero-denominator exception type and message are unchanged.docs/build_nesyarena_report.py:tests/test_nesyarena_report_matches_the_builder,tests/test_the_no_reason_violation_counterexamples, andtests/test_add_mult_deviation_figurespassed.A rescan is still required to prove the external findings are cleared. I cannot verify that locally because there is no Sonar instance here and the finding identifiers are not exposed by the scan interface.