feat(web): add social previews and template credit - #14
Merged
Merged
Conversation
eduardstan
force-pushed
the
fm/lp-social-preview
branch
from
July 30, 2026 15:57
3a2777e to
9adab21
Compare
eduardstan
force-pushed
the
fm/lp-social-preview
branch
from
July 30, 2026 16:25
9adab21 to
a7527fa
Compare
eduardstan
added a commit
that referenced
this pull request
Jul 31, 2026
* Add OpenGraph and Twitter social preview meta tags and template footer link * no-mistakes(review): Fix canonical social metadata and raster previews * no-mistakes(document): Document social metadata and format changed files * docs: update README.md to reflect example portrait PNG format * no-mistakes(review): Drop footer credit assertion from deployment-base check * no-mistakes(document): Document social previews and footer credit line * test: drop footer copyright year assertion from check-deployment-base * no-mistakes(review): emit og:type=article on blog posts only * no-mistakes(review): match blog posts relative to deployment base * no-mistakes(document): clarify portrait format in content schema comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Add OpenGraph and Twitter social preview meta tags to BaseLayout and add a discreet template credit link in Footer
What Changed
Risk Assessment
✅ Low: The requested social metadata behavior, canonical-page suppression, raster filtering, bundled preview image, documentation, and footer credit are implemented coherently; only one minor example-description inconsistency remains.
Testing
No baseline results were supplied. After restoring local dependencies, the focused production-build check and live Chrome verification passed for project-subpath social metadata, alternate-view suppression, the raster preview image, and the corrected discreet footer credit; rendered HTML and screenshot evidence were captured, and transient dependencies/build outputs were removed.
/tmp/no-mistakes-evidence/01KYSS959ZAG2ZP2CMSAQEQBPV/footer-credit.png)Evidence: Rendered home HTML containing social metadata
Evidence: Live browser verification
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
web/src/layouts/BaseLayout.astro:44- Pages such as/publications/year-asc/pass a variant-specific title while canonicalizing to/publications/. The resulting cards share oneog:urlbut advertise differentog:titlevalues, so crawler order can determine the canonical page’s preview title. Decide on canonical social metadata and expose it separately from the browser title at this shared layout boundary.web/src/layouts/BaseLayout.astro:49- The bundled and adopter-fixture portraits are SVG files, but Twitter/X image cards do not support SVG. Consequently, the template’s defaulttwitter:imagewill not render. Consider a crawler-compatible raster social-image field or omit unsupported image tags.🔧 Fix: Fix canonical social metadata and raster previews
1 info still open:
content/cv.yaml:31- Changing the bundled profile toportrait.pngleaves README.md’s example description claiming that the record exercises an SVG portrait. Update that sentence to describe the raster portrait and, if useful, note that its SVG source remains alongside it.✅ **Test** - passed
✅ No issues found.
npm ciandnpm ci --prefix webto restore this isolated worktree’s locked test dependenciesnpm run check:deployment-base— reproduced the new footer assertion failure, then passed after the fixRenderedhttp://127.0.0.1:4322/ledgerpress/in Chrome at 1440×1000 and visually inspected the footerEvaluated live OpenGraph/Twitter metadata plus the footer link target, visibility, and 11px colophon styling in Chromecurl --fail --silent --show-error http://127.0.0.1:4322/ledgerpress/to capture the final rendered HTML✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.