Skip to content

Fix for Firefox 7 not writing HTML to the print window #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for Firefox 7 not writing HTML to the print window #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions renderers/Base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ Ext.ux.Printer.BaseRenderer = Ext.extend(Object, {

var win = window.open('', name);

win.document.write(this.generateHTML(component));
win.document.close();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line really need to be moved up as well?


// gecko looses its document after document.close(). but fortunally waits with printing till css is loaded itself
if (Ext.isGecko) {
win.print();
win.close();
return;
}

win.document.write(this.generateHTML(component));
win.document.close();

this.doPrintOnStylesheetLoad.defer(10, this, [win]);
},

Expand Down