Avoid ConstraintImpl instances at runtime#353
Draft
PapyChacal wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
f93f0a2 to
1038f7d
Compare
1038f7d to
183c718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables inlining the verifiers in the generated code! One step towards actual macro compositions there.
In practice, for the example (in our tests) of:
The current code to enforce
lhs's constraint is:And with this change is:
Emphasis:
ConstraintImplinitialization and virtual invocation left, just code comparinglhstof32