Handle malformed HTTP 204 responses#248
Open
phoe wants to merge 1 commit into
Open
Conversation
Member
|
Looks good to me so far - The HTML file is the documentation source, so please update it to include your new feature docs. Thank you for the contribution! |
Author
|
OK, will do in a moment. I'll nonetheless want to test it beforehand, at least on our code. |
Author
|
Tested, works. Will update docs. Should I do it straight away, or after #250? I'd rather edit HTML here first so that this issue isn't blocked. |
Member
|
I believe there is no pressure other than what you feel. Do things in the order that suit you, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247
Please don't merge yet, I'll test it first with our proprietary code on Monday.
How do we test and document this? I don't see any kind of unit test suite that would allow me to add a test into. Is the documentation generated from something, or should I edit the HTML file directly?