Rename @edgedb/create to @gel/create #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
approved these changes
Jan 14, 2025
| const { stdout } = await execInLoginShell("edgedb --version"); | ||
| edgedbCliVersion = stdout.trim(); | ||
| logger(edgedbCliVersion); | ||
| const { stdout } = await execInLoginShell("gel --version"); |
There was a problem hiding this comment.
This is fine for now, but we have an issue pending to update this to use the CLI wrapper instead of this alternative way of installing the CLI. If you think it's easy enough to do (we already detect the package manager, so should be straightforward), maybe we can switch it now?
diksipav
force-pushed
the
create-pkg-edgedb-2gel
branch
from
9b72ac8 to
023f000
Compare
diksipav
added a commit
that referenced
this pull request
Jan 23, 2025
diksipav
added a commit
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.