Send service_name and service_job_id only if both are set #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we set `service_name` to `travis-ci` if `service_name` is unset, but that in combination with an empty `service_job_id` causes all such submitted results to end up in a single build (as they have the same job ID) instead of the expected behavior where each submitted result has a separate build. The API[0] states that we should either use repo token or _both_ service job ID and service name, so let's do just that. [0] https://docs.coveralls.io/api-introduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we set
service_nametotravis-ciifservice_nameisunset, but that in combination with an empty
service_job_idcauses allsuch submitted results to end up in a single build (as they have the same
job ID) instead of the expected behavior where each submitted result has
a separate build.
The API[0] states that we should either use repo token or both service
job ID and service name, so let's do just that.
[0] https://docs.coveralls.io/api-introduction