gcov: accommodate the execution_count format change in GCC 8.1 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of gcov's execution_count has been extended to indicate any unexecuted blocks in a single line, with a following '*': gcc-mirror/gcc@3cf7fdd This confuses cpp-coveralls and leads to a parsing error: Traceback (most recent call last): [...] coverage.append(int(cov_num)) ValueError: invalid literal for int() with base 10: '2*'
|
Is this potentially related to #126? I've seen this error too using GCC 8.1. |
|
The Travis build error is unrelated to this change https://travis-ci.org/eddyxu/cpp-coveralls/jobs/397341693#L491
which only happens on Python 3.3 This change passes on Python 2.7, 3.4, 3.5, and pypy. |
|
Thanks for providing the link to the upstream change, merging now as it seems safe. Ideally we should add some unit testing (using example gcov outputs), but such is life. |
ueno
added a commit
to ueno/p11-kit
that referenced
this pull request
Aug 24, 2018
To accommodate the gcov format change in gcc 8.1: eddyxu/cpp-coveralls#127 which is not yet available in the pip version.
ueno
added a commit
to ueno/p11-kit
that referenced
this pull request
Aug 27, 2018
To accommodate the gcov format change in gcc 8.1: eddyxu/cpp-coveralls#127 which is not yet available in the pip version.
ueno
added a commit
to p11-glue/p11-kit
that referenced
this pull request
Aug 28, 2018
To accommodate the gcov format change in gcc 8.1: eddyxu/cpp-coveralls#127 which is not yet available in the pip version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of gcov's execution_count has been extended to indicate any
unexecuted blocks in a single line, with a following '*':
gcc-mirror/gcc@3cf7fdd
This confuses cpp-coveralls and leads to a parsing error: