-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Case Insensitive Materials Redirects #36
Conversation
@DrDrij since I made changes to the yaml frontmatter to add in the |
@camriddell Correct, if the github action notices that a Markdown file has been updated it will sync it across to the website repository. If the most up to date version now exists on this website repo, then perhaps we should copy these Markdown files into their respective repositories? eg. copy this: https://raw.githubusercontent.com/econ-ark/econ-ark.org/d4f024f7fe86d26f44a49141d44a45c56a86e69e/_materials/Aiyagari.md into: https://raw.githubusercontent.com/econ-ark/REMARK/master/REMARKs/Aiyagari.md |
I see that this has conflicts, so presumably it is not ready to merge. Should it have a [WIP] (work in progress) label until ready to merge? And, @DrDrij, I presume you have the permissions necessary to merge it when it is no longer WIP? |
@camriddell: Pinging you on this. I'd love to get case insensitivity fixed. Let me know when it's ready to merge! |
This PR was more of a one time patch, in order to consider future updates to metadata, we'll need a separate build step- meaning we'll need to utilize an orphan branch to publish from (typically I'll need to converse with @DrDrij to make sure I don't interfere with anything else, but the envisioned change would be:
The reason for relying on an orphan branch like |
@camriddell is this still active? |
So I guess this was never merged, and now has conflicts. |
@alanlujan91 we can probably close issue as this should be a step in the build process of the website. I need to meet with @DrDrij to discuss what this will look like, but if we can have a GitHub Actions build step before the site is deployed we can do a lot of neat things— like I have set up in #75 |
Addresses the case-sensitivity in the materials urls via the github-pages supported
jekyll-redirect-from
plugin.Longer term solutions will require a larger rewrite of the site infrastructure (incorporating a custom jekyll build and a new github action, or using our own web server). In the meantime, this will solve most case sensitivity issues for the materials pages.