[bot] Execute example notebooks #1542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MridulS
reviewed
Mar 5, 2025
There was a problem hiding this comment.
The plots here look different (in cell 33), is this expected?
MridulS
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Cell 17 and Cell 25 have different plots too.
MridulS
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Cell 15 and Cell 22 have different plots too
MridulS
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Simulation plots are different here too.
|
What's the easiest way to see these differences? Open the branch locally?
…On Wed, Mar 5, 2025 at 4:00 PM Mridul Seth ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On examples/ConsumptionSaving/example_ConsGenIncProcessModel.ipynb
<#1542 (comment)>:
Simulation plots are different here too.
—
Reply to this email directly, view it on GitHub
<#1542 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFIK6ZIDYMPINJDSPJT2S5QXRAVCNFSM6AAAAABYGJADSOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRSGQ3TQMBXGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
MridulS
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Significant changes in the plot here too.
With so many notebooks, I'm not sure. I am just looking at the "rich diff" on github interface while comparing old plots with these new runs. |
MridulS
approved these changes
Mar 5, 2025
github-actions
bot
force-pushed
the
bot/update-notebooks
branch
from
c45bbf7 to
74666e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was [automatically generated] to re-execute the example notebooks for use in the documentation.
[automatically generated]: https://github.com/Econ-ARK/HARK/actions/workflows/execute-notebooks.yml