Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/irregular grid mapper #112

Open
wants to merge 47 commits into
base: develop
Choose a base branch
from

Conversation

mathleur
Copy link
Member

Create an irregular grid mapper which handles irregular grids and uses a different engine slicer

Copy link
Collaborator

@jameshawkes jameshawkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be continued... let's try some extractions on ORCA grids and see if it works, then we can tidy it up

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 336 lines in your changes are missing coverage. Please review.

Project coverage is 84.27%. Comparing base (c3f51b3) to head (85e1741).

Files Patch % Lines
...rmations/datacube_mappers/mapper_axis_decorator.py 0.00% 87 Missing ⚠️
tests/test_quad_tree.py 23.52% 78 Missing ⚠️
tests/test_orca_irregular_grid.py 24.00% 38 Missing ⚠️
polytope/datacube/quad_tree.py 78.37% 24 Missing ⚠️
tests/test_quadtree_indices.py 28.00% 18 Missing ⚠️
tests/test_quadtree_optimisation.py 33.33% 18 Missing ⚠️
tests/test_polytope_extract_fdb.py 34.61% 17 Missing ⚠️
polytope/engine/quadtree_slicer.py 70.21% 14 Missing ⚠️
tests/test_quadtree_edge_cases.py 38.88% 11 Missing ⚠️
polytope/engine/engine.py 40.00% 9 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #112      +/-   ##
===========================================
- Coverage    87.50%   84.27%   -3.23%     
===========================================
  Files           88      101      +13     
  Lines         7099     7754     +655     
===========================================
+ Hits          6212     6535     +323     
- Misses         887     1219     +332     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants