Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First search in installed packages #14

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

First search in installed packages #14

wants to merge 8 commits into from

Conversation

tmi
Copy link

@tmi tmi commented Nov 26, 2024

1/ Adding a new source for searching for libs -- in installed python binary packages. Those are produced eg here https://github.com/ecmwf/eckit/pull/152/commits . This additionally extend ld library path for transitive dependencies, assuming the found libs declare them accordingly
2/ Refactored the body of the main function so that each source is separated in its own (private) function
3/ Fine-grained control over which sources are allowed for package search using environment variables

@FussyDuck
Copy link

FussyDuck commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 16.32653% with 82 lines in your changes missing coverage. Please review.

Project coverage is 35.43%. Comparing base (39345dd) to head (ab59d12).

Files with missing lines Patch % Lines
findlibs/__init__.py 0.00% 82 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #14      +/-   ##
===========================================
- Coverage    41.91%   35.43%   -6.48%     
===========================================
  Files            4        6       +2     
  Lines          136      206      +70     
===========================================
+ Hits            57       73      +16     
- Misses          79      133      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmi tmi force-pushed the project/wheelify branch from fdd4763 to 6854f9e Compare November 28, 2024 11:25
findlibs/__init__.py Outdated Show resolved Hide resolved
@tmi tmi force-pushed the project/wheelify branch 4 times, most recently from 304111d to 6581389 Compare December 6, 2024 14:28
@tmi tmi force-pushed the project/wheelify branch 2 times, most recently from ef16d92 to d530acf Compare December 9, 2024 10:08
@tmi tmi force-pushed the project/wheelify branch from d530acf to 3508f77 Compare December 9, 2024 10:09
@tmi tmi force-pushed the project/wheelify branch from fe23b81 to 764d0cf Compare December 9, 2024 15:53
@tmi tmi marked this pull request as ready for review December 9, 2024 15:53
@tmi tmi force-pushed the project/wheelify branch from 764d0cf to 9ecc085 Compare December 10, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants