Make tools/bufr_compare_dir a plain sh script #235
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very minor simplification - drop the need for
ksh
from thetools/bufr_compare_dir
utility.At the Bureau of Meteorology we build a custom eccodes internally and our CI that tests this tool fails due to a lack of Korn shell on our test VMs. It's the only non ".ksh" script in the code-base that uses
ksh
, and it's easy enough to make it work with any POSIX shell, as per this pull request.