Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tools/bufr_compare_dir a plain sh script #235

Closed

Conversation

ivorblockley
Copy link

A very minor simplification - drop the need for ksh from the tools/bufr_compare_dir utility.

At the Bureau of Meteorology we build a custom eccodes internally and our CI that tests this tool fails due to a lack of Korn shell on our test VMs. It's the only non ".ksh" script in the code-base that uses ksh, and it's easy enough to make it work with any POSIX shell, as per this pull request.

@FussyDuck
Copy link

FussyDuck commented Aug 6, 2024

CLA assistant check
All committers have signed the CLA.

@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Aug 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (db8d725) to head (de3f598).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #235   +/-   ##
========================================
  Coverage    86.86%   86.86%           
========================================
  Files          784      784           
  Lines        62631    62631           
  Branches     11035    11035           
========================================
  Hits         54406    54406           
  Misses        8225     8225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn closed this Aug 7, 2024
@ivorblockley ivorblockley deleted the bufr_compare_dir_ksh_to_sh branch August 9, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants