Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cds and ads prompt #504

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update cds and ads prompt #504

merged 1 commit into from
Nov 1, 2024

Conversation

sandorkertesz
Copy link
Collaborator

@sandorkertesz sandorkertesz commented Nov 1, 2024

Related to #499

This PR:

  • Fixed issue when setting up cds source credentials via the prompt did not work.
  • Fixed issue when setting up ads source credentials via the prompt did not work.
  • Increased cdsapi dependency to version 0.7.2 to be compatible with the new CDS/ADS services.
  • Corrected documentation for ads.

Planned to be released as 0.10.9.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6730370). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage        ?   90.60%           
=======================================
  Files           ?      123           
  Lines           ?     8344           
  Branches        ?      361           
=======================================
  Hits            ?     7560           
  Misses          ?      653           
  Partials        ?      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz merged commit 2f3a9b9 into main Nov 1, 2024
103 checks passed
@sandorkertesz sandorkertesz deleted the hotfix/update-cds-prompt branch November 1, 2024 14:07
sandorkertesz added a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants