Skip to content

chore(refactor, test): Move test utils into own subdirectory #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025

Conversation

aaron-hopkinson
Copy link
Contributor

Description

Grouped together all dataset creation testing related utilities (which aren't themselves tests) into a utils subdirectory.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@github-actions github-actions bot added the tests label May 2, 2025
@aaron-hopkinson aaron-hopkinson changed the title chore(test): Move test utils into own subdirectory chore(refactor, test): Move test utils into own subdirectory May 2, 2025
@b8raoult
Copy link
Collaborator

Can you take the opportunity of that PR to split tests in units/integration.

@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev May 23, 2025
@aaron-hopkinson
Copy link
Contributor Author

Can you take the opportunity of that PR to split tests in units/integration.

@b8raoult following the conversations the other week – I suspect the definition of unit vs integration vs other tests might generate some discussion, so I've made this change as a separate PR so we can tackle this independently.

@aaron-hopkinson aaron-hopkinson moved this from Now In Progress to Reviewers needed in Anemoi-dev Jun 19, 2025
HCookie
HCookie previously approved these changes Jul 1, 2025
@HCookie
Copy link
Member

HCookie commented Jul 1, 2025

Resolve the conflicts then we will merge

@aaron-hopkinson aaron-hopkinson merged commit 863b875 into main Jul 1, 2025
68 checks passed
@aaron-hopkinson aaron-hopkinson deleted the chore/move_test_utils branch July 1, 2025 11:12
@github-project-automation github-project-automation bot moved this from Reviewers needed to Done in Anemoi-dev Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants