fix: normalise in place to reduce memory #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids storing large intermediate results during the normalization by computing it in-place, e.g.
x[..., :] = x[..., :] * self._norm_mul + self._norm_add # old version x.mul_(self._norm_mul).add_(self._norm_add) # new version
Note that the in_place argument still works as expected, only the actual calculation is changed to be done in-place.
For 9km data the old version resulted in mini-peaks during the normalizer:
This lines up with storing two additional intermediate results (multiplication, addition) @~8GB batch size in the old version.