Skip to content

allow control-wrapper to be overridden by provided component #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

allow control-wrapper to be overridden by provided component #2482

wants to merge 12 commits into from

Conversation

kchobantonov
Copy link
Contributor

@kchobantonov kchobantonov commented Aug 21, 2025 •
edited
Loading

fixing #2443

@netlify Netlify
Copy link

netlify bot commented Aug 21, 2025 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit bf7af15
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/68d9b1340750cb000848d644
😎 Deploy Preview https://deploy-preview-2482--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kchobantonov
Copy link
Contributor Author

@sdirix please review

sdirix
sdirix reviewed Sep 22, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have minor comments

@coveralls
Copy link

Coverage Status

coverage: 82.791%. remained the same
when pulling a9d8096 on kchobantonov:injectable-control-wrapper
into 6542785 on eclipsesource:master.

@kchobantonov kchobantonov requested a review from sdirix September 23, 2025 21:44
@kchobantonov
Copy link
Contributor Author

@sdirix all fixed - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix Awaiting requested review from sdirix

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kchobantonov @coveralls @sdirix